Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for MemorySwap #15352

Closed
wants to merge 3 commits into from
Closed

Add support for MemorySwap #15352

wants to merge 3 commits into from

Conversation

tomesink
Copy link
Contributor

This PR adds support for MemorySwapConfiguration based on the following logic:

  • If memorySwapConfiguration.swapBehavior is not set, there will be no change to the kubelet configuration.
  • If memorySwapConfiguration.swapBehavior is set to an empty string, kubelet config will contain memorySwap: "".
  • If memorySwapConfiguration.swapBehavior is set to "UnlimitedSwap", kubelet config will contain memorySwap: UnlimitedSwap.

Fixes: #14950

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 27, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign justinsb for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 27, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @tomesm. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jan-kantert
Copy link

@hakman @zetaab is there anything missing to get this merged? this feature makes certain usecases much more economic (i.e. most java workloads)

@hakman
Copy link
Member

hakman commented Jul 11, 2023

@tomesm If you have time to go through the review, please let me know and I will try to review this PR.

@hakman hakman mentioned this pull request Jul 14, 2023
Merged
@hakman
Copy link
Member

hakman commented Jul 17, 2023

Thanks, @tomesm for the inspiration and sorry for the delay in review.
I created a slightly simpler version of it which will be part of kOps 1.27.0.

@hakman hakman closed this Jul 17, 2023
@tomesink
Copy link
Contributor Author

Hey @hakman , your version looks better. Im glad I inspired you :)

@hakman
Copy link
Member

hakman commented Jul 17, 2023

I hope you try again @tomesm. I would be happy to review your PRs. 👍

@jan-kantert jan-kantert mentioned this pull request Aug 25, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hakman hakman Awaiting requested review from hakman

@zetaab zetaab Awaiting requested review from zetaab

Assignees
No one assigned
Labels
area/api cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Swap Support
4 participants
@tomesink @k8s-ci-robot @jan-kantert @hakman